Fix signature for generic structure hooks #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A generic structure hook is expected to return a value of the type that it accepts as an argument.
|
Thanks. Are there established ways of testing type annotations? |
|
I've only worked on a couple of typed projects but I think that type-checking the unit tests or some other corpus of examples should give coverage. |
|
How do you test for failures though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic structure hook is expected to return a value of the type that it accepts as an argument.
I feel guilty submitting a two-byte PR but I noticed that there aren't any tests that invoke mypy. Would it be useful to do some type checking as part of the test suite?
Closes #106.