[hermes] Bump dependencies in Rust and Go #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
ali-bahjati
approved these changes
Jul 21, 2023
Reisen
force-pushed
the
reisen/libp2p-cache-leak-fix
branch
from
4fbf9b4 to
4c858fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After digging deep to try and resolve a memory leak error in hermes, I tracked it down to libp2p. It seems this was already fixed previously in go-libp2p-pubsub and so wasn't a problem in our own codebase after all.
This PR therefore bumps libp2p to the latest versions to get ahead of problems like this, it also fixes the
Cargo.lockpinned versions for our existing Rust dependencies so it continues to build against latest nightly.