Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo lock #356

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Cargo lock #356

merged 2 commits into from
Apr 26, 2023

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Apr 26, 2023 •
edited
Loading

CI's cargo test started failing because the tokio-stream crate was being resolved to 0.1.13 (a new version) instead of 0.1.12 and that version has a bug tokio-rs/tokio#5655 .

There are two ways of fixing this :

  • Pinning tokio-stream to 0.1.12 in Cargo.toml
  • Pinning all dependencies by commiting Cargo.lock and using the flag --locked in cargo build and cargo test.

This PR does option 2.

@guibescos guibescos marked this pull request as ready for review April 26, 2023 02:17
@jayantk jayantk merged commit fe892d4 into main Apr 26, 2023
@jayantk jayantk deleted the pin-deps branch April 26, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guibescos @jayantk