Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upcoming trainings #9744

Merged
merged 5 commits into from
Mar 12, 2022
Merged

Update upcoming trainings #9744

merged 5 commits into from
Mar 12, 2022

Conversation

The-Compiler
Copy link
Member

Also see https://twitter.com/the_compiler/status/1501247315809640464

Submitted but not accepted yet trainings commented out for now.

@The-Compiler The-Compiler added type: docs documentation improvement, missing or needing clarification needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Mar 8, 2022
@The-Compiler
Copy link
Member Author

Preview: https://pytest--9744.org.readthedocs.build/en/9744/

hoefling
hoefling reviewed Mar 8, 2022
View reviewed changes
doc/en/index.rst Outdated

- `Professional Testing with Python <https://www.python-academy.com/courses/specialtopics/python_course_testing.html>`_, via `Python Academy <https://www.python-academy.com/>`_, February 1st to 3rd, 2022, Leipzig (Germany) and remote.
Also see `previous talks and blogposts <talks.html>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit: a crossref instead of a hardcoded link could be used here.

Suggested change
Also see `previous talks and blogposts <talks.html>`_.
Also see :doc:`previous talks and blogposts <talks>`.

@The-Compiler
Copy link
Member Author

I'd actually propose to remove the link to previous talks/trainings completely - what do you think, @nicoddemus @hoefling? I feel like we're not doing a very good job at keeping it updated, so I don't think it really deserves to be linked that prominently.

@hoefling
Copy link
Member

I wouldn't miss it TBH, but right now this is the only spot that makes the reader aware of the "Talks and tutorials" chapter existence.

Just a side note, this wouldn't be an issue anymore when/If the theme is switched to furo (which I would love to see). I see the TOC properly listing all chapters (preview), so the talks are easily accessible from any page.

@nicoddemus
Copy link
Member

I feel like we're not doing a very good job at keeping it updated, so I don't think it really deserves to be linked that prominently.

Not sure, feels like showing them in the front page gives them the importance they deserve. If we bury this down into the docs somewhere else, I feel they will go unnoticed.

@The-Compiler
Copy link
Member Author

Ok, let's keep it around then. I updated it to a crossref. I also added another talk I did in 2021 while I was at it.

@The-Compiler The-Compiler merged commit d306ec0 into pytest-dev:main Mar 12, 2022
@github-actions github-actions bot mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoefling hoefling hoefling left review comments

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-Compiler @hoefling @nicoddemus