fixtures: document FixtureDef's attributes #9546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the two cases (direct/indirect fixture) clearer. The try-catch forces the reader to jump around.
nicoddemus
approved these changes
Feb 15, 2022
nicoddemus
added
the
needs backport
|
@nicoddemus Thanks for the review. This is just some internal docs so I'm going to skip the backport. |
|
Wouldn't be better to do it anyway to avoid any potential conflicts? |
|
I personally prefer to deal with conflicts if/when they happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a refactor commit to make some code flow clearer.
This conflicts with #9420 so not meant for merging right away.