Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As discussed in Discord, move 3.10 changelog to trivial #9053

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

nicoddemus
Copy link
Member

This was backported to 6.2.x, but we agreed this should
actually a trivial change and go into 6.2.5, instead of a new 6.3.0.

This was backported to `6.2.x`, but we agreed this should
actually a trivial change and go into `6.2.5`, instead of a new `6.3.0`.
@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 28, 2021
@nicoddemus nicoddemus marked this pull request as ready for review August 28, 2021 15:01
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, given that #8494 really only has internal/tooling changes - thus it seems reasonable to mark it as trivial.

Also we released 6.2.4 with "Fixed assertion rewriting on Python 3.10." (#8539), implying that it already supported Python 3.10 - so this hardly seems like a new feature from an user's perspective anyways.

@The-Compiler The-Compiler mentioned this pull request Aug 29, 2021
@nicoddemus nicoddemus merged commit 014fa61 into pytest-dev:main Aug 29, 2021
@nicoddemus nicoddemus deleted the change-8494-to-trivial branch August 29, 2021 13:52
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Aug 29, 2021
@nicoddemus
Copy link
Member Author

Backport: #9056

nicoddemus added a commit that referenced this pull request Aug 29, 2021
[6.2.x] Merge pull request #9053 from nicoddemus/change-8494-to-trivial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants