Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] py36 plus #7811

Closed
wants to merge 6 commits into from
Closed

[WIP] py36 plus #7811

wants to merge 6 commits into from

Conversation

asottile
Copy link
Member

@asottile asottile commented Sep 28, 2020

still TODO:

  • audit TYPE_CHECKING

@asottile asottile mentioned this pull request Sep 28, 2020
@The-Compiler
Copy link
Member

I know this is WIP, but FWIW I think you can also remove .travis.yml entirely.

@Zac-HD
Copy link
Member

Zac-HD commented Sep 28, 2020

  • # type: comments

https://pypi.org/project/com2ann/ might help.

@asottile
Copy link
Member Author

  • # type: comments

https://pypi.org/project/com2ann/ might help.

yeah the problem is a good percentage of them have some things that need manual attention (I started with com2ann and then said "maybe later"):

  • a lot of them are forward annotations
  • some can be refactored as follows:
x: VeryLongTypeNameHere = (
    expression_here
)

=>

x: VeryLongTypeNameHere
x = expression_here

@asottile
Copy link
Member Author

asottile commented Oct 1, 2020

I'm going to be splitting this out into a bunch of PRs so this is easier to merge -- right now it's going to be a real pain to keep rebasing / managing conflicts as I finish things up 👍

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to combine lots of unrelated changes, but overall it seems that most of it is around adding fstrings and type checking.

I would totally support smaller steps of atomic changes, like remove py35 jobs and update python_requires, followed by update pre-commit linters.

@asottile
Copy link
Member Author

asottile commented Oct 2, 2020

@ssbarnea did you not read my last comment?

@ssbarnea
Copy link
Member

ssbarnea commented Oct 2, 2020

@ssbarnea did you not read my last comment?

Yep, but after I added the comment.

@asottile asottile closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants