Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: improve bash check #7526

Merged
merged 1 commit into from
Jul 22, 2020
Merged

testing: improve bash check #7526

merged 1 commit into from
Jul 22, 2020

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Jul 21, 2020 •
edited
Loading

Address post-merge comments in #7520 from @graingert and @The-Compiler.

The-Compiler
The-Compiler approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!

@nicoddemus nicoddemus merged commit 2a8dcc9 into pytest-dev:master Jul 22, 2020
@bluetech bluetech deleted the win-bash-2 branch July 24, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@The-Compiler The-Compiler The-Compiler approved these changes

@graingert graingert graingert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluetech @graingert @The-Compiler @nicoddemus