Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package: typing, cleanup #6461

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Package: typing, cleanup #6461

merged 5 commits into from
Jan 30, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 14, 2020 •
edited
Loading

TODO:

@blueyed blueyed mentioned this pull request Jan 14, 2020
Closed
@blueyed blueyed force-pushed the test-package-upstream branch from b18399f to 8b39c75 Compare January 15, 2020 06:01
@blueyed blueyed mentioned this pull request Jan 15, 2020
Merged
1 task
@RonnyPfannschmidt
Copy link
Member

overall this looks good, part of me want to think a bit about it, so i'l sleep over it

@blueyed blueyed force-pushed the test-package-upstream branch from 8b39c75 to e64b8f3 Compare January 17, 2020 10:45
@blueyed blueyed changed the base branch from features to master January 21, 2020 20:03
@blueyed blueyed force-pushed the test-package-upstream branch from e64b8f3 to 979b97c Compare January 21, 2020 20:03
@blueyed blueyed changed the title [RFC/WIP] Package: typing, cleanup Package: typing, cleanup Jan 21, 2020
@blueyed blueyed changed the title Package: typing, cleanup [blocked] Package: typing, cleanup Jan 21, 2020
nicoddemus
nicoddemus reviewed Jan 21, 2020
View reviewed changes
src/_pytest/nodes.py Outdated Show resolved Hide resolved
@blueyed blueyed force-pushed the test-package-upstream branch from 979b97c to 123f71f Compare January 22, 2020 23:17
@blueyed blueyed changed the title [blocked] Package: typing, cleanup Package: typing, cleanup Jan 22, 2020
@blueyed
Copy link
Contributor Author

blueyed commented Jan 22, 2020

Should be good now from my POV.

@blueyed blueyed mentioned this pull request Jan 24, 2020
Closed
bluetech
bluetech reviewed Jan 25, 2020
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice cleanup to me. I have a couple of questions.

src/_pytest/python.py Show resolved Hide resolved
src/_pytest/nodes.py Outdated Show resolved Hide resolved
@blueyed blueyed force-pushed the test-package-upstream branch 2 times, most recently from 560039d to 69660fd Compare January 25, 2020 15:48
blueyed
blueyed commented Jan 25, 2020
View reviewed changes
src/_pytest/python.py Outdated Show resolved Hide resolved
@blueyed blueyed force-pushed the test-package-upstream branch from 69660fd to e117430 Compare January 25, 2020 16:04
bluetech
bluetech reviewed Jan 25, 2020
View reviewed changes
src/_pytest/python.py Outdated Show resolved Hide resolved
@blueyed blueyed force-pushed the test-package-upstream branch from e117430 to ced0870 Compare January 25, 2020 16:18
@blueyed
Clean up Package.__init__
817c094 
Makes `parent` a required arg, which would have failed before via
`parent.session` anyway.

Keeps calling/passing unused args for B/C.
@blueyed
Sync {Session,Package}.gethookproxy
6b7e1a2 
Only copy'n'paste error from c416b1d.
@blueyed
Move common code between Session and Package to FSCollector
e2934c3
@blueyed blueyed force-pushed the test-package-upstream branch from ced0870 to e2934c3 Compare January 25, 2020 18:04
@blueyed

This comment has been minimized.

Sign in to view
@nicoddemus

This comment has been minimized.

Sign in to view
@blueyed

This comment has been minimized.

Sign in to view
@blueyed blueyed merged commit 28b8f3c into pytest-dev:master Jan 30, 2020
@blueyed blueyed deleted the test-package-upstream branch January 30, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech left review comments

@nicoddemus nicoddemus nicoddemus left review comments

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blueyed @RonnyPfannschmidt @nicoddemus @bluetech