More CSS fine-tuning #5604
Merged
More CSS fine-tuning #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5604 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 117 117
Lines 25775 25775
Branches 2495 2495
=======================================
Hits 24773 24773
Misses 697 697
Partials 305 305Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Great, thanks a lot @timhoffm! We definitely appreciate the love you are giving to pytest's docs. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5602.
Fixes a regresssion from Improve CSS layout #5602. The contents list items unintendedly got a margin in between. This is removed again (before/after):
Removed the header backlinks in the section "Contributing". The main motivation is to not style the headings like links. While this could also be overridden with additional CSS, I decided to just remove the backlinks. Since most of the other pages do not have TOCs, headings in the pytest docs usually do not have backlinks. Additionally, IMHO the semantics of a heading backlink is not quite intuitive (clicking on a heading brings you to the TOC which is only structurally but not sematically related to the section); and I don't think the actual action "Go to TOC" is really needed here.
before:
after: