Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comparison of byte strings (supersedes #5267) #5495

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jun 25, 2019

Supersedes #5267
Fixes #5260

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #5495 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5495      +/-   ##
=========================================
+ Coverage   96.07%   96.1%   +0.02%     
=========================================
  Files         117     117              
  Lines       25550   25701     +151     
  Branches     2473    2536      +63     
=========================================
+ Hits        24548   24699     +151     
+ Misses        698     697       -1     
- Partials      304     305       +1
Impacted Files Coverage Δ
testing/test_assertion.py 97.56% <100%> (+0.02%) ⬆️
src/_pytest/assertion/util.py 95.01% <100%> (+0.15%) ⬆️
src/_pytest/assertion/rewrite.py 95.98% <0%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aefb24...3f2344e. Read the comment docs.

@asottile asottile merged commit 3f3f3e7 into pytest-dev:master Jun 26, 2019
@nicoddemus nicoddemus deleted the blueyed/cmp-bytes branch June 26, 2019 09:05
@nicoddemus
Copy link
Member Author

nicoddemus commented Jun 26, 2019

I had explicitly added @blueyed as reviewer because he wrote the original PR 😬 ... Oh well 😁

@asottile
Copy link
Member

/o\ oops -- my bad

@blueyed
Copy link
Contributor

blueyed commented Jun 26, 2019

@nicoddemus
Thanks for having picked it up, and improved it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing assertion rewriting message with byte strings
3 participants