Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken/unused PytestPluginManager.addhooks #5448

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

nicoddemus
Copy link
Member

The function has been deprecated for ages and the PLUGIN_MANAGER_ADDHOOKS constant doesn't even exist since 3.0.

Because the function is clearly broken, this change doesn't even require a CHANGELOG.

The function has been deprecated for ages and
the PLUGIN_MANAGER_ADDHOOKS constant doesn't even exist since 3.0.

Because the function is clearly broken, this change doesn't even
require a CHANGELOG.
@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #5448 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5448      +/-   ##
==========================================
+ Coverage   95.96%   95.99%   +0.03%     
==========================================
  Files         114      114              
  Lines       25502    25498       -4     
  Branches     2479     2479              
==========================================
+ Hits        24473    24477       +4     
+ Misses        723      715       -8     
  Partials      306      306
Impacted Files Coverage Δ
src/_pytest/config/__init__.py 94.62% <ø> (+0.28%) ⬆️
src/_pytest/doctest.py 95.43% <0%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dcf1f...7513d87. Read the comment docs.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 240828d into pytest-dev:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants