Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Merge pull request #5393 from nicoddemus/unittest-self-5390 #5399

Merged
merged 1 commit into from
Jun 5, 2019
Merged

[4.6] Merge pull request #5393 from nicoddemus/unittest-self-5390 #5399

merged 1 commit into from
Jun 5, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Jun 5, 2019

item.obj is again a bound method on TestCase function items

item.obj is again a bound method on TestCase function items
@nicoddemus
Copy link
Member

Thanks for picking this up. 👍

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #5399 into 4.6-maintenance will decrease coverage by 2.69%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           4.6-maintenance    #5399     +/-   ##
==================================================
- Coverage            94.28%   91.59%   -2.7%     
==================================================
  Files                  115      115             
  Lines                26362    26369      +7     
  Branches              2603     2603             
==================================================
- Hits                 24855    24152    -703     
- Misses                1178     1893    +715     
+ Partials               329      324      -5
Impacted Files Coverage Δ
src/_pytest/unittest.py 94.27% <100%> (+0.06%) ⬆️
testing/test_unittest.py 99.11% <100%> (+0.02%) ⬆️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/test_session.py 17.72% <0%> (-82.28%) ⬇️
testing/test_runner_xunit.py 29.82% <0%> (-70.18%) ⬇️
testing/test_runner.py 34.7% <0%> (-61.61%) ⬇️
testing/test_resultlog.py 53.6% <0%> (-46.4%) ⬇️
testing/test_skipping.py 66.11% <0%> (-29.73%) ⬇️
testing/test_pytester.py 55.21% <0%> (-27.89%) ⬇️
src/_pytest/reports.py 68.96% <0%> (-26.11%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937f945...92432ac. Read the comment docs.

@nicoddemus nicoddemus merged commit 8076f48 into pytest-dev:4.6-maintenance Jun 5, 2019
@asottile asottile deleted the backport_5393 branch June 5, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants