Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--lf now skips colletion of files without failed tests #5185

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

nicoddemus
Copy link
Member

Fix #5172

@nicoddemus nicoddemus requested a review from blueyed April 28, 2019 19:28
@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #5185 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5185      +/-   ##
============================================
+ Coverage     96.11%   96.12%   +<.01%     
============================================
  Files           115      115              
  Lines         25980    26007      +27     
  Branches       2561     2566       +5     
============================================
+ Hits          24971    24999      +28     
  Misses          706      706              
+ Partials        303      302       -1
Impacted Files Coverage Δ
src/_pytest/cacheprovider.py 97.83% <100%> (+0.18%) ⬆️
testing/test_cacheprovider.py 99.73% <100%> (ø) ⬆️
src/_pytest/assertion/util.py 98.14% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc0cea...08734bd. Read the comment docs.

src/_pytest/cacheprovider.py Outdated Show resolved Hide resolved
@nicoddemus nicoddemus force-pushed the lf-skip-files branch 2 times, most recently from 1308055 to 7fc801d Compare April 28, 2019 23:22
@nicoddemus nicoddemus merged commit 766fc23 into pytest-dev:features Apr 29, 2019
@nicoddemus nicoddemus deleted the lf-skip-files branch April 29, 2019 00:49
@blueyed
Copy link
Contributor

blueyed commented Apr 29, 2019

Thanks again.. this will help me with working on the pytest plugin / conftest to use pytest with Django's own tests (> 6000 IIRC), and basically all unittest based.
Ref: https://code.djangoproject.com/ticket/30415

@nicoddemus
Copy link
Member Author

Awesome!

@blueyed
Copy link
Contributor

blueyed commented May 29, 2019

I think this might have caused #5301 - started looking into it, but might not finish it today anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants