Adding test cases for unrolling an iterable #5062 #5155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## features #5155 +/- ##
===========================================
- Coverage 96.03% 93.73% -2.3%
===========================================
Files 115 115
Lines 25948 25970 +22
Branches 2563 2564 +1
===========================================
- Hits 24918 24344 -574
- Misses 726 1305 +579
- Partials 304 321 +17
Continue to review full report at Codecov.
|
blueyed
reviewed
Apr 23, 2019
| package_msg = pipe.read() | ||
| package_msg = package_msg[:-2] | ||
| if package_msg: | ||
| self.write_line(package_msg) |
There was a problem hiding this comment.
Is this meant for debugging / this PR only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests that will check if the pytest terminal output from using assertion statements with "all" or "any" will unroll and produce the same output as assertion statements inside of a for-loop. These tests are related to issue #5062 and two of them currently fail. Once the implementation in #5103 is finished, all three of these tests should pass.