-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox: split default posargs, use --lsof with single job only #4847
Conversation
The plan is to use |
f007230
to
1d21a3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4847 +/- ##
==========================================
- Coverage 94.29% 93.17% -1.12%
==========================================
Files 113 113
Lines 25172 25172
Branches 2499 2499
==========================================
- Hits 23735 23455 -280
- Misses 1100 1379 +279
- Partials 337 338 +1
Continue to review full report at Codecov.
|
You think I can reach codecov by clicking on the image (https://codecov.io/gh/pytest-dev/pytest/pull/4847?src=pr&el=tree), but all other links still time out to me. |
No, I've meant that it will show missing coverage. |
I will compare it manually/rebase it when codecov works again. |
OK, thanks! |
Waiting for codecov status. |
3452460
to
7aa4cc5
Compare
7aa4cc5
to
9186d62
Compare
9186d62
to
7c42ece
Compare
@nicoddemus |
Needs the fix from #4851, i.e. should also get done against features then. |
7c42ece
to
9186d62
Compare
This is required for combining. Use it for new lsof facor also.
9186d62
to
baf4e5c
Compare
baf4e5c
to
f8160f7
Compare
@@ -65,7 +65,7 @@ jobs: | |||
|
|||
- stage: baseline | |||
env: TOXENV=py27-pexpect,py27-trial | |||
- env: TOXENV=py37-numpy-xdist | |||
- env: TOXENV=py37-lsof-numpy-xdist PYTEST_COVERAGE=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that lsof
is only used to cover the code for it (we do not react / handle its warnings anyway), this could also be done with a faster job for less overhead maybe.
This is required for combining.