tox: add generic xdist factor #4753
Conversation
|
Motivated by using Is it sensible to use |
| coverage: coverage combine | ||
| coverage: coverage report | ||
| passenv = USER USERNAME COVERAGE_* TRAVIS | ||
| setenv = | ||
| _PYTEST_TOX_ARGS=--lsof |
There was a problem hiding this comment.
i suspect this needs a comment that taking off lsoff for xdist is intended
we still need some thing to run lsoff against tho
There was a problem hiding this comment.
--lsof was not used with the previous py27-xdist / py37-xdist jobs, that's why I've removed it here. Will try to keep it in general.
I don't think it is necessary... we run xdist to ensure we are not breaking things with it, and we run both |
My intention is to make the builds faster. I suggest to use |
Oh sorry, I didn't catch that meaning at first. I think that's fair. 👍 |
blueyed
changed the title
.travis.yml
Outdated
| python: 'pypy2.7-6.0' | ||
| - env: TOXENV=pypy3-xdist PYTEST_NO_COVERAGE=1 | ||
| python: 'pypy3.5-6.0' | ||
|
|
.travis.yml
Outdated
| @@ -31,16 +31,16 @@ matrix: | |||
| jobs: | |||
| include: | |||
| # Coverage tracking is slow with pypy, skip it. | |||
| - env: TOXENV=pypy PYTEST_NO_COVERAGE=1 | |||
| - env: TOXENV=pypy-xdist PYTEST_NO_COVERAGE=1 | |||
There was a problem hiding this comment.
i believe we need to ensure lsof on pypy due to gc differences in order to catch unwanted issues
There was a problem hiding this comment.
Ok.
This is not related to pypy-xdist failing on Windows though, is it?
https://ci.appveyor.com/project/pytestbot/pytest/builds/22239624/job/2hns6pgk71weay26
There was a problem hiding this comment.
no, thats probably an issue with execnet
Codecov Report
@@ Coverage Diff @@
## features #4753 +/- ##
============================================
- Coverage 95.7% 95.69% -0.02%
============================================
Files 113 113
Lines 25028 25028
Branches 2484 2484
============================================
- Hits 23953 23950 -3
Misses 760 760
- Partials 315 318 +3
Continue to review full report at Codecov.
|
blueyed
changed the title
|
Reverted this back to only change tox.ini for now. |
No description provided.