fix #4649 - also transfer markers to keywordmapping #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
fix-4649
branch
from
2031d9b
to
18b2c1a
Compare
RonnyPfannschmidt
changed the title
as it turns out it is distinct from nodekeywords and behaves completely different
RonnyPfannschmidt
force-pushed
the
fix-4649
branch
from
18b2c1a
to
f28b834
Compare
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
- Coverage 95.73% 95.72% -0.02%
==========================================
Files 111 111
Lines 24783 24787 +4
Branches 2455 2454 -1
==========================================
+ Hits 23727 23728 +1
Misses 747 747
- Partials 309 312 +3
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is distinct from nodekeywords
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;