Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config.warn, Node.warn and pytest_logwarning #4542

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

nicoddemus
Copy link
Member

Fix #3078

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (features@75e93e5). Click here to learn what that means.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             features    #4542   +/-   ##
===========================================
  Coverage            ?   95.76%           
===========================================
  Files               ?      111           
  Lines               ?    24895           
  Branches            ?     2456           
===========================================
  Hits                ?    23841           
  Misses              ?      746           
  Partials            ?      308
Flag Coverage Δ
#docs 29.43% <23.33%> (?)
#doctesting 29.43% <23.33%> (?)
#linting 29.43% <23.33%> (?)
#linux 95.59% <93.33%> (?)
#nobyte 92.4% <93.33%> (?)
#numpy 93.21% <93.33%> (?)
#pexpect 41.85% <33.33%> (?)
#py27 93.79% <93.33%> (?)
#py34 91.91% <93.33%> (?)
#py35 91.93% <93.33%> (?)
#py36 91.95% <93.33%> (?)
#py37 93.95% <93.33%> (?)
#trial 93.21% <93.33%> (?)
#windows 93.94% <93.33%> (?)
#xdist 93.82% <93.33%> (?)
Impacted Files Coverage Δ
testing/test_warnings.py 98.81% <ø> (ø)
testing/test_config.py 99.42% <ø> (ø)
testing/deprecated_test.py 100% <ø> (ø)
src/_pytest/terminal.py 91.7% <ø> (ø)
testing/test_assertrewrite.py 83.46% <0%> (ø)
src/_pytest/assertion/rewrite.py 95.6% <100%> (ø)
testing/acceptance_test.py 98.28% <100%> (ø)
src/_pytest/hookspec.py 100% <100%> (ø)
testing/test_pytester.py 87.45% <100%> (ø)
src/_pytest/warnings.py 88.88% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e93e5...b7e8171. Read the comment docs.

@nicoddemus
Copy link
Member Author

Fixed now (hopefully)

@nicoddemus
Copy link
Member Author

Ready for additional review/merge

@nicoddemus nicoddemus merged commit 8563364 into pytest-dev:features Dec 18, 2018
@nicoddemus nicoddemus deleted the remove-legacy-warn branch December 18, 2018 21:11
@nicoddemus
Copy link
Member Author

Merging as the failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants