Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix/improve reporting of test_request_garbage #4457

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

nicoddemus
Copy link
Member

  • Run it in a subprocess to reduce possible intereference from the outer pytest
  • Print the leaked objects to see if they provide any hints

* Run it in a subprocess to reduce possible intereference from the outer pytest
* Print the leaked objects to see if they provide any hints
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #4457 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4457      +/-   ##
==========================================
+ Coverage    95.9%   95.91%   +<.01%     
==========================================
  Files         111      111              
  Lines       25085    25085              
  Branches     2447     2447              
==========================================
+ Hits        24059    24061       +2     
+ Misses        724      723       -1     
+ Partials      302      301       -1
Flag Coverage Δ
#docs 30.09% <ø> (+0.07%) ⬆️
#doctesting 30.09% <ø> (+0.07%) ⬆️
#linting 30.09% <ø> (+0.07%) ⬆️
#linux 95.73% <100%> (-0.01%) ⬇️
#nobyte 92.67% <0%> (ø) ⬆️
#numpy 93.45% <0%> (-0.02%) ⬇️
#pexpect 41.87% <ø> (-0.03%) ⬇️
#py27 94.04% <100%> (+0.01%) ⬆️
#py34 92.18% <100%> (+0.06%) ⬆️
#py35 92.2% <100%> (+0.06%) ⬆️
#py36 92.22% <100%> (+0.06%) ⬆️
#py37 94.11% <100%> (ø) ⬆️
#trial 93.45% <0%> (-0.02%) ⬇️
#windows 94.13% <100%> (ø) ⬆️
#xdist 93.98% <0%> (ø) ⬆️
Impacted Files Coverage Δ
testing/python/fixture.py 99.24% <100%> (ø) ⬆️
src/_pytest/capture.py 93.87% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860bc50...9e522c9. Read the comment docs.

@nicoddemus nicoddemus merged commit 8facf1d into pytest-dev:master Nov 24, 2018
@nicoddemus nicoddemus deleted the test-request-garbage branch November 24, 2018 12:08
@nicoddemus
Copy link
Member Author

If someone can merge this in the merge-master-into-features branch it would be great, I'm away from my computer the entire day at a conference 😁

@blueyed
Copy link
Contributor

blueyed commented Nov 24, 2018

If someone can merge this in the merge-master-into-features branch

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants