Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't string-compare version numbers #4308

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Don't string-compare version numbers #4308

merged 1 commit into from
Nov 5, 2018

Conversation

asottile
Copy link
Member

@asottile asottile commented Nov 5, 2018

Resolves #4306

@asottile
Copy link
Member Author

asottile commented Nov 5, 2018

the py37 job seems pretty sad for this change :S

it passes locally however:

  py37: commands succeeded
  congratulations :)

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure is unrelated, i'd prefer if we used or followed up with or used either a recent setuptools version parse or a packaging version parse

@asottile asottile merged commit 176d274 into pytest-dev:master Nov 5, 2018
@asottile asottile deleted the compare_versions_with_loose_version branch November 5, 2018 20:42
@blueyed
Copy link
Contributor

blueyed commented Nov 5, 2018

@RonnyPfannschmidt

i'd prefer if we used or followed up with or used either a recent setuptools version parse or a packaging version parse

Please create an issue then.

Altogether I would have liked to see a regression test for this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants