Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS py37 on Travis #4217

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix MacOS py37 on Travis #4217

merged 1 commit into from
Oct 24, 2018

Conversation

nicoddemus
Copy link
Member

This has been failing as of 2018-10-23 while installing gcc with
this message:

	==> Installing numpy dependency: gcc
	==> Downloading https://homebrew.bintray.com/bottles/gcc-8.2.0.high_sierra.bottl
	######################################################################## 100.0%
	==> Pouring gcc-8.2.0.high_sierra.bottle.1.tar.gz
	Error: The `brew link` step did not complete successfully
	The formula built, but is not symlinked into /usr/local
	Could not symlink include/c++
	Target /usr/local/include/c++
	already exists. You may want to remove it:
	  rm '/usr/local/include/c++'
	To force the link and overwrite all conflicting files:
	  brew link --overwrite gcc
	To list all files that would be deleted:
	  brew link --overwrite --dry-run gcc
	Possible conflicting files are:
	/usr/local/include/c++ -> /usr/local/Caskroom/oclint/0.13.1,17.4.0/oclint-0.13.1/include/c++

Example failure: https://travis-ci.org/pytest-dev/pytest/jobs/444989259

@codecov
Copy link

codecov bot commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #4217 into master will decrease coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4217      +/-   ##
==========================================
- Coverage   95.81%   94.73%   -1.08%     
==========================================
  Files         109      109              
  Lines       24295    24378      +83     
  Branches     2395     2399       +4     
==========================================
- Hits        23278    23095     -183     
- Misses        721      988     +267     
+ Partials      296      295       -1
Flag Coverage Δ
#docs 28.51% <ø> (ø) ⬆️
#doctesting 28.51% <ø> (ø) ⬆️
#linting 28.51% <ø> (ø) ⬆️
#linux 93.75% <ø> (-1.85%) ⬇️
#nobyte 91.32% <ø> (-0.57%) ⬇️
#numpy 91.58% <ø> (-1.32%) ⬇️
#pexpect ?
#py27 92.85% <ø> (-1.11%) ⬇️
#py34 91.58% <ø> (-0.62%) ⬇️
#py35 91.59% <ø> (-0.62%) ⬇️
#py36 92.33% <ø> (-1.58%) ⬇️
#py37 92.07% <ø> (-0.15%) ⬇️
#trial 91.58% <ø> (-1.32%) ⬇️
#windows 94.03% <ø> (-0.01%) ⬇️
#xdist 93.29% <ø> (-0.5%) ⬇️
Impacted Files Coverage Δ
testing/test_argcomplete.py 18.75% <0%> (-46.88%) ⬇️
src/_pytest/_argcomplete.py 29.41% <0%> (-44.12%) ⬇️
testing/test_pdb.py 52.4% <0%> (-42.52%) ⬇️
src/_pytest/debugging.py 72.86% <0%> (-21.71%) ⬇️
src/_pytest/unittest.py 86.47% <0%> (-7.65%) ⬇️
testing/test_conftest.py 96.72% <0%> (-2.88%) ⬇️
src/_pytest/helpconfig.py 97.19% <0%> (-1.87%) ⬇️
testing/test_terminal.py 99.21% <0%> (-0.79%) ⬇️
src/_pytest/pytester.py 86.58% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bced74...28dbffd. Read the comment docs.

nicoddemus
nicoddemus commented Oct 23, 2018
View reviewed changes
.travis.yml
@@ -47,15 +47,21 @@ jobs:
env: TOXENV=py37
before_install:
- brew update
# update gcc first because it was breaking the py37 update as of 2018-10-23;
# might not be necessary in the future
- rm '/usr/local/include/c++'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following what brew recommends in its error message:

	Could not symlink include/c++
	Target /usr/local/include/c++
	already exists. You may want to remove it:
	  rm '/usr/local/include/c++'

@jaraco does this seem correct to you? Any other suggestion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I'm mis-remembering, who contributed the macos builds was not @jaraco.

@jirikuncar what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this symlink in the Travis image already? You might want to ls -l it in the beginning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens when also upgrading numpy (https://travis-ci.org/pytest-dev/pytest/jobs/444989259#L933), which maybe can be avoided with some option to "brew upgrade python" to not upgrade dependents? (should be faster then, too)

@blueyed
Copy link
Contributor

blueyed commented Oct 23, 2018 •
edited
Loading

Pushed a commit that uses brew upgrade --ignore-dependencies python, feel free to revert/amend.

Edit: reverted (d04965b), still failed in the same way (upgrading numpy => gcc).

@nicoddemus
Copy link
Member Author

Thanks for chipping in @blueyed. 👍

Let's see what @jirikuncar has to say.

blueyed referenced this pull request in kovidgoyal/kitty Oct 24, 2018
@kovidgoyal
Disabe brew python upgrade since it is failing for some reason on Travis
d24977d
@nicoddemus
Attempt to fix macosx build setup
28dbffd 
This has been failing as of 2018-10-23 while installing gcc with
this message:

	==> Installing numpy dependency: gcc
	==> Downloading https://homebrew.bintray.com/bottles/gcc-8.2.0.high_sierra.bottl
	######################################################################## 100.0%
	==> Pouring gcc-8.2.0.high_sierra.bottle.1.tar.gz
	Error: The `brew link` step did not complete successfully
	The formula built, but is not symlinked into /usr/local
	Could not symlink include/c++
	Target /usr/local/include/c++
	already exists. You may want to remove it:
	  rm '/usr/local/include/c++'
	To force the link and overwrite all conflicting files:
	  brew link --overwrite gcc
	To list all files that would be deleted:
	  brew link --overwrite --dry-run gcc
	Possible conflicting files are:
	/usr/local/include/c++ -> /usr/local/Caskroom/oclint/0.13.1,17.4.0/oclint-0.13.1/include/c++
@nicoddemus nicoddemus changed the title [WIP] Attempt to fix MacOS py37 on Travis Fix MacOS py37 on Travis Oct 24, 2018
@nicoddemus
Copy link
Member Author

Well let's get this merged, as having every PR failing because of this is distracting.

@nicoddemus
Copy link
Member Author

(We will need at least 1 approval before we can merge this btw)

@blueyed blueyed merged commit 9df1b03 into pytest-dev:master Oct 24, 2018
@nicoddemus nicoddemus deleted the fix-macos-py37-travis branch October 24, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed approved these changes

@jirikuncar jirikuncar Awaiting requested review from jirikuncar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoddemus @blueyed