Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging when invalid syntax is passed to the -m option #4057

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Improve error messaging when invalid syntax is passed to the -m option #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2179c3
Improve error messaging when invalid syntax is passed to the -m option
jeffreyrack Oct 1, 2018
7a6d16c
Adding .rst to end of changelog fragment filename.
jeffreyrack Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/4051.trivial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Imrpove Error messaging when Invalid Python Syntax is passed through the ``-m`` option to limit what marks to run against.
5 changes: 4 additions & 1 deletion src/_pytest/mark/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ def __getitem__(self, subname):

def matchmark(colitem, markexpr):
"""Tries to match on any marker names, attached to the given colitem."""
return eval(markexpr, {}, MarkMapping.from_item(colitem))
try:
return eval(markexpr, {}, MarkMapping.from_item(colitem))
except SyntaxError as e:
raise SyntaxError(str(e) + "\nMarker expression must be valid Python!")


def matchkeyword(colitem, keywordexpr):
Expand Down
12 changes: 12 additions & 0 deletions testing/test_mark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,18 @@ def test_unmarked():
deselected_tests = dlist[0].items
assert len(deselected_tests) == 2

def test_invalid_m_option(self, testdir):
testdir.makepyfile(
"""
def test_a():
pass
"""
)
result = testdir.runpytest("-m bogus/")
result.stdout.fnmatch_lines(
["INTERNALERROR> Marker expression must be valid Python!"]
)

def test_keywords_at_node_level(self, testdir):
testdir.makepyfile(
"""
Expand Down