Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into features #4021

Merged

Conversation

nicoddemus
Copy link
Member

No description provided.

nicoddemus and others added 30 commits September 6, 2018 18:56
Improve pre-commit detection for changelog filenames
Fixes pytest-dev#3965.

Has to work around tox-dev/tox#706.

No coverage for pluggymaster builds is OK though anyway.
This test fails *very* rarely when running in xdist.
Also added an example using one pattern per line
Fix rendering of the ini example for python_files
…licy

Review backward compatibility policy
Faster to install and will retry uploads on connection errors.
Unfortunately we need to get a `py.path.local` object to perform the fnmatch
operation, it is different from the standard `fnmatch` module because it
implements its own custom logic. So we need to use `py.path` to perform
the fnmatch for backward compatibility reasons.

Ideally we should be able to use a "pure path" in `pathlib` terms (a path
not bound to the file system), but we don't have those in pylib.

Fix pytest-dev#3973
…rewrite

This way we don't need to have real file system path, which prevents the
original pytest-dev#3973 bug.
This should increase coverage for subprocesses, where previously
`source` paths were used only from the config file, but not the initial
`--source` argument.
Without this caplog.record_tuples etc is not available anymore when using
`--pdb`.
Fix assertion rewriter crash if cwd changes mid-testing
nicoddemus and others added 20 commits September 19, 2018 12:52
seems this subdir is now .pytest_cache not .cache
Fix scope determination with indirect parameters
logging: del item.catch_log_handler only in teardown
…mix_python_2

Fix UnicodeDecodeError in assertion with mixed non-ascii bytes repr + text
…3749

Fix 'Package has no len()' error during collection
Include Python 3.7 on getting started doc
@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #4021 into features will increase coverage by <.01%.
The diff coverage is 92.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #4021      +/-   ##
============================================
+ Coverage      94.5%   94.51%   +<.01%     
============================================
  Files           107      109       +2     
  Lines         23734    23865     +131     
  Branches       2357     2366       +9     
============================================
+ Hits          22430    22556     +126     
- Misses          993     1000       +7     
+ Partials        311      309       -2
Flag Coverage Δ
#doctesting 29.36% <35%> (+0.89%) ⬆️
#linux 94.36% <88.88%> (-0.02%) ⬇️
#nobyte 0% <0%> (ø) ⬆️
#numpy 28.26% <34%> (+0.12%) ⬆️
#pexpect 0% <0%> (ø) ⬆️
#pluggymaster ?
#py27 92.64% <88.88%> (+0.02%) ⬆️
#py34 92.13% <88.19%> (-0.05%) ⬇️
#py35 92.14% <88.19%> (-0.05%) ⬇️
#py36 92.71% <88.19%> (-0.04%) ⬇️
#py37 92.34% <88.19%> (-0.05%) ⬇️
#trial 31.28% <37%> (+0.08%) ⬆️
#windows 93.82% <88.19%> (-0.03%) ⬇️
#xdist 18.6% <27%> (+0.12%) ⬆️
Impacted Files Coverage Δ
src/_pytest/monkeypatch.py 93.23% <ø> (ø) ⬆️
src/_pytest/assertion/rewrite.py 95.34% <100%> (-0.35%) ⬇️
src/_pytest/compat.py 96.62% <100%> (+0.07%) ⬆️
src/_pytest/unittest.py 86.47% <100%> (+0.08%) ⬆️
src/_pytest/main.py 96.19% <100%> (ø) ⬆️
testing/python/fixture.py 99.23% <100%> (ø) ⬆️
src/_pytest/paths.py 100% <100%> (ø) ⬆️
testing/test_paths.py 100% <100%> (ø)
testing/python/collect.py 99.29% <100%> (ø) ⬆️
testing/test_cacheprovider.py 99.7% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83802d1...fcc5b6d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 93.831% when pulling fcc5b6d on nicoddemus:merge-master-into-features into 83802d1 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit e03a19f into pytest-dev:features Sep 23, 2018
@nicoddemus nicoddemus deleted the merge-master-into-features branch September 23, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants