Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needless message printed with --failed-first and no failed tests #3853 #3912

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

dhirensr
Copy link
Contributor

@dhirensr dhirensr commented Aug 30, 2018

No description provided.

@coveralls
Copy link

coveralls commented Aug 30, 2018

Coverage Status

Coverage decreased (-0.3%) to 92.253% when pulling 84a033f on dhirensr:needless_message into a605ad4 on pytest-dev:features.

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #3912 into features will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #3912      +/-   ##
============================================
+ Coverage      92.2%   92.25%   +0.04%     
============================================
  Files            52       52              
  Lines         10016    10016              
============================================
+ Hits           9235     9240       +5     
+ Misses          781      776       -5
Impacted Files Coverage Δ
src/_pytest/cacheprovider.py 98.42% <100%> (ø) ⬆️
src/_pytest/terminal.py 94.34% <0%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a605ad4...84a033f. Read the comment docs.

@@ -0,0 +1,2 @@
Removed ``"run all (no recorded failures)"`` message printed with ``--failed-first`` and ``--last-failed`` when there are no failed tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhirensr I took the liberty of updating the CHANGELOG a bit: we don't need to explicitly write about internal details like which tests were updated for example; those are not interesting for final users, which are the public the CHANGELOG is meant for. 😁

@nicoddemus nicoddemus merged commit 64f0068 into pytest-dev:features Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants