Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Issue #3824 #3856

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Resolving Issue #3824 #3856

merged 2 commits into from
Aug 22, 2018

Conversation

jennirinker
Copy link

Expanding the documentation a bit to be more explicit about how to search for multiple glob patterns when changing test collection.

# content of pytest.ini, tox.ini, or setup.cfg file (replace "pytest"
# with "tool:pytest" for setup.cfg)
[pytest]
python_files=test_*.py example_*.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd put a space around the =, nbd though

@jennirinker
Copy link
Author

I thought I was matching the formatting in tox.ini, but I just checked and it has spaces around the equals signs in there. So I have no idea where I got the tight spacing from.

Can you guys add the spaces on your end? Or do I need to resubmit the PR?

@nicoddemus
Copy link
Member

@jennirinker you and us maintainers can edit the files directly on the GitHub interface, there's a "pen" icon in the toolbar of each file in the "Files changed" tab. 😉

@nicoddemus
Copy link
Member

Thanks a ton @jennirinker for following up with this! 😁

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.638% when pulling 5a7aa12 on jennirinker:master into 2137e2b on pytest-dev:master.

@nicoddemus nicoddemus merged commit 17eec5b into pytest-dev:master Aug 22, 2018
@jennirinker
Copy link
Author

Well, now I've learned something else. I should check to see if we can also edit PRs in GitLab.

My thanks to you guys for developing such an awesome tool. Between pytest, sphinx, and CI, it's nice to have some snazzy automated testing/docs generation.

@nicoddemus
Copy link
Member

Thanks, we appreciate the compliment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants