Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a bunch of unicode bugs in pytester.py #3848

Merged
merged 5 commits into from
Aug 23, 2018
Merged

fixed a bunch of unicode bugs in pytester.py #3848

merged 5 commits into from
Aug 23, 2018

Commits on Aug 22, 2018

  1. fixed a bunch of unicode bugs in pytester.py

    @wimglenn
    wimglenn committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    89446af View commit details
    Browse the repository at this point in the history

  2. Add a failing testcase for PR pytest-dev#3848

    @wimglenn
    wimglenn authored Aug 22, 2018
    Configuration menu
    Copy the full SHA
    8e2c7b4 View commit details
    Browse the repository at this point in the history

  3. strip trailing whitespace

    @wimglenn
    wimglenn authored Aug 22, 2018
    Configuration menu
    Copy the full SHA
    b08e156 View commit details
    Browse the repository at this point in the history

  4. More unicode whack-a-mole 

    It seems pytest's very comprehensive CI sniffed out a few other places with similar bugs.  Ideally we should find all the places where args are not stringy and solve it at the source, but who knows how many people are relying on the implicit string conversion.  See [here](https://github.com/pytest-dev/pytest/blob/master/src/_pytest/config/__init__.py#L160-L166) for one such problem area (args with a single py.path.local instance is converted here, but a list or tuple containing some are not).
    @wimglenn
    wimglenn authored Aug 22, 2018
    Configuration menu
    Copy the full SHA
    917b99e View commit details
    Browse the repository at this point in the history

  5. Fix CHANGELOG formatting

    @nicoddemus
    nicoddemus authored Aug 22, 2018
    Configuration menu
    Copy the full SHA
    8804c73 View commit details
    Browse the repository at this point in the history