-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hooks #3614
Upgrade hooks #3614
Conversation
hmmmmmm! I'll have to look at this some more |
there's a bit of an edge case with the
going to save that for a separate branch since that bit is riskier and just do |
Hah black changed what line the code ends up on breaking the test. I'll fix this when I'm at a computer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i skimmed the changes and overall its getting much better - @ambv is doing a great job with getting blacks more awesome
should i sort out the conflict my other merge triggered or do we leave it for later |
I can reapply pretty easily |
quite a bit of stuff here: