Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ImportWarnings regarding package resolution #3096

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

nicoddemus
Copy link
Member

The problem is described/discussed in #3061

Ideally this should be a temporary solution until we find a proper one
which gets rid of the warning

@nicoddemus
Copy link
Member Author

cc @blueyed @asottile

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merging this to unblock builds

we should fix the root cause (whatever it is) and then remove this. Perhaps a comment indicating that with a ticket link here would be helpful?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.565% when pulling 4af623e on nicoddemus:import-warnings into 794fb19 on pytest-dev:master.

The problem is described/discussed in pytest-dev#3061

Ideally this should be a temporary solution until we find a proper one
which gets rid of the warning
@nicoddemus
Copy link
Member Author

@asottile agreed. I will now see what's the matter with py27-pluggymaster... 😓

Since 0.6.1 pluggy has been turned into a package
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 92.556% when pulling b6b36bc on nicoddemus:import-warnings into 794fb19 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 92.556% when pulling b6b36bc on nicoddemus:import-warnings into 794fb19 on pytest-dev:master.

@nicoddemus
Copy link
Member Author

Merging to unblock PRs

@nicoddemus nicoddemus merged commit 962aede into pytest-dev:master Jan 9, 2018
@nicoddemus nicoddemus deleted the import-warnings branch January 9, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants