Add acceptance tests #2664
Add acceptance tests #2664
Conversation
|
@Lothiraldan sorry for taking so long on this one, i am under the impression that it needs a bit of discussion but i'm currently swamped with other things |
|
No problem, I needed them for my own plugin. Could we keep the pull-request open so we don't forget about it and plugins authors might find the pull-request and use them? |
|
i#ll keep it open until i get to it |
|
@RonnyPfannschmidt anything else needed here? |
|
@nicoddemus this one follows up with an odea of another pr, but i need to detail handling it |
|
#2207 just got merged and i'm thinking about how to combine with this one i will probably need a bit more time to get to it |
RonnyPfannschmidt
added
the
type: enhancement
|
#3623 will probably take this one over or supersede this, correct? |
|
@nicoddemus thanks for the note, i will take a look at pulling them over/integrating them after #3623 is merged as it will take a while to sort them from what we have inside our own examples |
|
#3636 has also been merged. |
|
@nicoddemus i still need to make time to actually do this ^^ |
|
Oh sure, just a gentle ping! 👍 |
|
now that we have the example dir and moved many more elaborate tests there, i wonder if the tests that helped to inspired the structural idea actually still make sense to move in |
|
I feel the same way, I'll leave up to you to decide. I'm OK with closing this now. |
|
@Lothiraldan i want to thank you again from bringing this up and creating it, it had been a valuable source for sorting out the final implementation however a side-effect of the final implementation was, that it already includes quite a number of elements and thus this initial idea/demo has been superseded by that |
Following of #2207 and #2643, add some "examples" or "acceptance" test files in the acceptance directory.
They are not yet tested automatically.