Fix flake8 issues - #2581

[andras-tim]

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• Add a new news fragment into the changelog folder
  • name it $issue_id.$type for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
• Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
• Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

• Add yourself to AUTHORS;

[coveralls]

Coverage decreased (-0.01%) to 92.116% when pulling b2a5ec3 on andras-tim:fix-flake8-issues into 3578f4e on pytest-dev:master.

[andras-tim]

You can add the EP2017 sprint tag to this pull request too 😉

[nicoddemus]

I like this PR as this fixes the long standing issue of pep8 compatibility.

There's some points to consider though:

1. This will change history a lot; I dislike this in general but for pytest I think this will be a win in the long term;
2. This will cause some short term pain as we merge PRs which are not pep8 compatible because we were still ignoring some warnings at the time they were written; no big deal, should be short lived pain.
3. This will cause some conflicts when next we have to merge with features; no big deal, I've already made a local merge and fixed the conflicts and updated the features only code using autopep8.

So in the end I think this should be merged, just wanted to clarify all pain points so everyone is on the same page. 😉

After this is merged we probably need some docs and a tox env that runs autopep8 with the correct parameters to simplify fixing pep8 errors for contributors. For reference I used:

autopep8 --in-place -r --max-line-length=120 --exclude vendored_packages _pytest testing

[nicoddemus]

Question: should we squash this before merging?

[RonnyPfannschmidt]

i like the full history in this case

[andras-tim]

@nicoddemus feel free you squashing or not.

But one thing you should know, the autopep8 can't fix all pep8 rules properly and the flake8 has more rules than pep8.

Thx guys the fast reply.

[nicoddemus]

i like the full history in this case

I don't see the value in this case but that is fine.

Shall we merge this then?

[nicoddemus]

But one thing you should know, the autopep8 can't fix all pep8 rules properly and the flake8 has more rules than pep8

Thanks, noted. Do you have a suggestion for a better suited tool?

[andras-tim]

Thanks, noted. Do you have a suggestion for a better suited tool?

Unfortunately no, I don't.

[nicoddemus]

Unfortunately no, I don't.

I see, thanks.

If nobody opposes this, I plan to merge this later tonight and update the features branch accordingly. I will also add a tox environment that runs autopep8 on the code with the correct options, and update the development guide instructing to use it.

[andras-tim]

@nicoddemus, what's your exact plan w/ autopep8 in tox? I think this can be useful when a user wants to fix his coding problems, but I do not prefer to run by CI. (Who will be the owner? Will it be squashed or amended? What will be, when autopep8 can't fix all problem?)

So I prefer to use autopep8 as a one-time tool, what anyone can use when he gets new errors, and too lazy to fix by hand.

[nicoddemus]

what's your exact plan w/ autopep8 in tox?

My idea is to just use tox like a convenience around a virtual environment with known dependencies. In that case tox just facilitates creating a virtual environment with the required dependencies and executing some commands. We already have tox envs that act like this: regen updates the local .rst files with local pytest commands, docs generates the documentation, etc. This type of usage is becoming common in the tox community, see tox-dev/tox#427.

Like regen, this new tox environment is just a local development tool, never to be run on CI.

[andras-tim]

Like regen, this new tox environment is just a local development tool, never to be run on CI.

ok 👍