Test Outcomes as BaseException - fix #580 #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Jun 11, 2017
CHANGELOG.rst
Outdated
| @@ -1361,6 +1361,11 @@ time or change existing behaviors in order to make them less surprising/more use | |||
| Thanks Mathieu Agopian for the report and Ronny Pfannschmidt for the PR. | |||
|
|
|||
| - fix issue 1029: transform errors when writing cache values into pytest-warnings | |||
| 2.8.1 | |||
| ----------------------------- | |||
There was a problem hiding this comment.
Why are you adding an entry for 2.8.1?
There was a problem hiding this comment.
i re-based the code - this one will go away
nicoddemus
reviewed
Jun 11, 2017
changelog/580.feature
Outdated
| @@ -0,0 +1 @@ | |||
| make pytest.fail/skip/xfail instances of BaseException | |||
There was a problem hiding this comment.
I think it would be nice to explain the change with some context to end-users, something like:
Exceptions raised by
pytest.fail,pytest.skipandpytest.xfailnow subclassBaseException, making them harder to be caught unintentionally by normal code.
There was a problem hiding this comment.
Also if we will release a new major version, should we add this in a "backward incompatibility" section perhaps?
|
@nicoddemus i did realize that we may need to do a major release for this one due to changing the base-class of exposed types |
RonnyPfannschmidt
force-pushed
the
fix-580
branch
3 times, most recently
from
26ec52f
to
9c4a1d4
Compare
RonnyPfannschmidt
force-pushed
the
fix-580
branch
2 times, most recently
from
30d42de
to
c81380d
Compare
RonnyPfannschmidt
force-pushed
the
fix-580
branch
3 times, most recently
from
260545e
to
693bb32
Compare
RonnyPfannschmidt
force-pushed
the
fix-580
branch
from
693bb32
to
06a4933
Compare
RonnyPfannschmidt
changed the title
miketheman
added a commit
to miketheman/pytest-socket
that referenced
this pull request
Sep 6, 2017
As of pytest 3.2.0, the internal outcome class no longer inherits from Exception, rather from BaseException. This was reported in pytest-dev/pytest#580 and changed in pytest-dev/pytest#2490 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added a commit
to miketheman/pytest-socket
that referenced
this pull request
Sep 6, 2017
As of pytest 3.2.0, the internal outcome class no longer inherits from Exception, rather from BaseException. This was reported in pytest-dev/pytest#580 and changed in pytest-dev/pytest#2490 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
$issue_id.$typefor example (588.bug)removal,feature,bugfix,vendor,docortrivialbugfix,vendor,docortrivialfixes, targetmaster; for removals or features targetfeatures;