remove pytest internal usage of the namespace hook #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
changed the title
RonnyPfannschmidt
force-pushed
the
namespace-hook
branch
from
21c2dcf
to
22cb978
Compare
|
the xdist failure is most interesting |
|
#2321 could be considered a blocker, a decission is needed |
|
the xfail is probably a bad idea, for now i do not want to merge it, its no longer sane to try this for 3.1 |
RonnyPfannschmidt
changed the title
RonnyPfannschmidt
force-pushed
the
namespace-hook
branch
from
434ca5c
to
8ac6231
Compare
… builtin namespaces
RonnyPfannschmidt
force-pushed
the
namespace-hook
branch
from
8ac6231
to
afb1778
Compare
RonnyPfannschmidt
changed the title
nicoddemus
approved these changes
Apr 21, 2017
|
Hmm sorry, just now I saw your comment @RonnyPfannschmidt... should I revert this merge? |
|
Its fine, i dir put in a workaround that works by kerping a single hook in pytest |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 24, 2020
Make it a real module instead. This was initially added in 9b58d6e (pytest-dev#2315), when removing support for `pytest_namespace`. Not sure if it ever worked "properly", but currently `import pytest.collect` and `from pytest.collect import File` do not work (but with this patch). This is only relevant for (backward) compatibility, but the more it appears to make sense to move it into a lazily loaded, separate file.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 11, 2020
Make it a real module instead. This was initially added in 9b58d6e (pytest-dev#2315), when removing support for `pytest_namespace`. Not sure if it ever worked "properly", but currently `import pytest.collect` and `from pytest.collect import File` do not work (but with this patch). This is only relevant for (backward) compatibility, but the more it appears to make sense to move it into a lazily loaded, separate file.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 12, 2020
Make it a real module instead. This was initially added in 9b58d6e (pytest-dev#2315), when removing support for `pytest_namespace`. Not sure if it ever worked "properly", but currently `import pytest.collect` and `from pytest.collect import File` do not work (but with this patch). This is only relevant for (backward) compatibility, but the more it appears to make sense to move it into a lazily loaded, separate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopening of the prior pr #2280