Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.0.4 #2050

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Release 3.0.4 #2050

merged 2 commits into from
Nov 11, 2016

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 9, 2016 •
edited
Loading

Builds:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.79% when pulling ab27429 on nicoddemus:release-3.0.4 into fc304b8 on pytest-dev:master.

@nicoddemus
Copy link
Member Author

Two Travis failures:

IMHO those are not release-blocking.

@nicoddemus
Copy link
Member Author

Same doctesting failure on AppVeyor.

@The-Compiler
Copy link
Member

The diff LGTM

@nicoddemus
Copy link
Member Author

Any thoughts on the failures? Are they release blocking or should we move on with the release? 😁

@The-Compiler
Copy link
Member

After having a closer look, I think they're "fine" as well.

@nicoddemus
Copy link
Member Author

@hpk42, @RonnyPfannschmidt any opinions here?

@hpk42
Copy link
Contributor

hpk42 commented Nov 11, 2016

i am fine -- too busy with pluggy, tox and other releases to check in any detail. but i wouldn't know what speaks against it :)

@nicoddemus nicoddemus merged commit ad4ef4f into pytest-dev:master Nov 11, 2016
@nicoddemus nicoddemus deleted the release-3.0.4 branch November 11, 2016 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @coveralls @The-Compiler @hpk42