-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed collection of classes with custom __new__
method. Fixes #1579.
#1759
Fixed collection of classes with custom __new__
method. Fixes #1579.
#1759
Conversation
Thanks! Looks good! Could you please rebase it into the latest master? Unfortunately the |
@@ -49,6 +49,10 @@ | |||
* ImportErrors in plugins now are a fatal error instead of issuing a | |||
pytest warning (`#1479`_). Thanks to `@The-Compiler`_ for the PR. | |||
|
|||
* Fixed collection of classes with custom ``__new__`` method. | |||
Fixes (`#1579`_). Thanks to `@Stranger6667`_ for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop the parens there 😉
Done! |
Rebased, now everything should be OK! |
Thanks! Definitely something I did run into in the past as well. |
This is great @Stranger6667, thanks for coming to the sprint! |
@tomviner |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
master
; for new features, targetfeatures
;AUTHORS
;CHANGELOG.rst
CHANGELOG
, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.