Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed collection of classes with custom __new__ method. Fixes #1579. #1759

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fixed collection of classes with custom __new__ method. Fixes #1579. #1759

merged 1 commit into from
Jul 25, 2016

Conversation

Stranger6667
Copy link
Contributor

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;
  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage increased (+0.004%) to 92.294% when pulling c1bcf19 on Stranger6667:issue1579-invalid-class into 018acc6 on pytest-dev:master.

@nicoddemus
Copy link
Member

Thanks! Looks good!

Could you please rebase it into the latest master? Unfortunately the CHANGELOG must have conflicted now that I merged another PR. 😞

@@ -49,6 +49,10 @@
* ImportErrors in plugins now are a fatal error instead of issuing a
pytest warning (`#1479`_). Thanks to `@The-Compiler`_ for the PR.

* Fixed collection of classes with custom ``__new__`` method.
Fixes (`#1579`_). Thanks to `@Stranger6667`_ for the PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the parens there 😉

@Stranger6667
Copy link
Contributor Author

Done!

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage increased (+0.004%) to 92.294% when pulling de10ccc on Stranger6667:issue1579-invalid-class into 655df7f on pytest-dev:master.

@Stranger6667
Copy link
Contributor Author

Rebased, now everything should be OK!
@nicoddemus

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling f7ad173 on Stranger6667:issue1579-invalid-class into d37af20 on pytest-dev:master.

@The-Compiler The-Compiler merged commit a2b04d0 into pytest-dev:master Jul 25, 2016
@The-Compiler
Copy link
Member

Thanks! Definitely something I did run into in the past as well.

@tomviner
Copy link
Contributor

This is great @Stranger6667, thanks for coming to the sprint!

@Stranger6667 Stranger6667 deleted the issue1579-invalid-class branch July 26, 2016 05:23
@Stranger6667
Copy link
Contributor Author

@tomviner
Thank you for the help on the sprint :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants