Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfailing test for #568 #1659

Merged
merged 2 commits into from
Jun 27, 2016
Merged

xfailing test for #568 #1659

merged 2 commits into from
Jun 27, 2016

Conversation

RonnyPfannschmidt
Copy link
Member

.

@coveralls
Copy link

coveralls commented Jun 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.389% when pulling 41c0edb on RonnyPfannschmidt:failtest-586 into f2bb3df on pytest-dev:features.

The-Compiler
The-Compiler reviewed Jun 25, 2016
View reviewed changes
testing/test_mark.py
pass

""")
(base_item, sub_item, sub_item_other), rec = testdir.inline_genitems(p)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this (nested unpacking) supported on 2.6?

@The-Compiler
Copy link
Member

#586 is "python.raises examples are unclear" - please amend the commit to point to the right issue.

@RonnyPfannschmidt RonnyPfannschmidt changed the title xfailing test for #586 xfailing test for #568 Jun 25, 2016
omarkohl
omarkohl reviewed Jun 25, 2016
View reviewed changes
testing/test_mark.py

@pytest.mark.issue568
@pytest.mark.xfail(reason="markers smear, needs fixing")
def test_mark_decorator_subclass_does_not_propagate_to_base2(self, testdir):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the test is probably wrong

@coveralls
Copy link

coveralls commented Jun 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.346% when pulling 95b8395 on RonnyPfannschmidt:failtest-586 into 2af3a7a on pytest-dev:features.

@coveralls
Copy link

coveralls commented Jun 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.346% when pulling 95b8395 on RonnyPfannschmidt:failtest-586 into 2af3a7a on pytest-dev:features.

@nicoddemus
Copy link
Member

@RonnyPfannschmidt could you please fix the PR as people mentioned and push an amended version? Thanks! 😁

@coveralls
Copy link

coveralls commented Jun 27, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 92.09% when pulling 76756c0 on RonnyPfannschmidt:failtest-586 into 2af3a7a on pytest-dev:features.

@nicoddemus nicoddemus merged commit ccd395f into pytest-dev:features Jun 27, 2016
@RonnyPfannschmidt RonnyPfannschmidt deleted the failtest-586 branch August 21, 2016 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RonnyPfannschmidt @coveralls @The-Compiler @nicoddemus @omarkohl