-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #510 by adding a describing skip marker on empty parameterize #1530
Conversation
also fml for formatting fixes |
LGTM |
while working on the features branch, i noticed a correct skip that is checking for an apparently missing attribute |
@RonnyPfannschmidt could you take a look at the failing AppVeyor build? |
@nicoddemus it seems that one is related to the config filename on non-posix fix |
@RonnyPfannschmidt could you rebase this and try again? This is fixed on |
unlike the marker based one its not composable
include the argument names to help determining the fixture/parametrization
778ae7c
to
afc5c7e
Compare
@nicoddemus i figured the underlying issue, the one on master was not composable |
i removed the old hack and always use the marker this has the upside of always composing and the downside of hiding one of the error in case of a double empty parametrize |
Thanks, the new code looks better indeed. 😁 |
this might need to go to features
also we might want to consider using a xfail marker with run=False instead of skip