Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #510 by adding a describing skip marker on empty parameterize #1530

Merged
merged 4 commits into from
May 30, 2016

Conversation

RonnyPfannschmidt
Copy link
Member

this might need to go to features

also we might want to consider using a xfail marker with run=False instead of skip

@RonnyPfannschmidt
Copy link
Member Author

also fml for formatting fixes

@nicoddemus
Copy link
Member

LGTM

@RonnyPfannschmidt
Copy link
Member Author

while working on the features branch, i noticed a correct skip that is checking for an apparently missing attribute

@nicoddemus
Copy link
Member

@RonnyPfannschmidt could you take a look at the failing AppVeyor build?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus it seems that one is related to the config filename on non-posix fix

@RonnyPfannschmidt RonnyPfannschmidt changed the title fix #510 by adding a describing skip marker on empty parameterize [wip] fix #510 by adding a describing skip marker on empty parameterize Apr 26, 2016
@nicoddemus
Copy link
Member

@RonnyPfannschmidt could you rebase this and try again? This is fixed on master already.

unlike the marker based one its not composable
include the argument names to help determining the fixture/parametrization
@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus i figured the underlying issue, the one on master was not composable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.204% when pulling afc5c7e on RonnyPfannschmidt:fix-510 into 436e13a on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt changed the title [wip] fix #510 by adding a describing skip marker on empty parameterize fix #510 by adding a describing skip marker on empty parameterize May 30, 2016
@RonnyPfannschmidt
Copy link
Member Author

i removed the old hack and always use the marker

this has the upside of always composing and the downside of hiding one of the error in case of a double empty parametrize

@nicoddemus
Copy link
Member

Thanks, the new code looks better indeed. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants