-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 1496 - xfail with condition keyword #1524
Merged
RonnyPfannschmidt
merged 1 commit into
pytest-dev:master
from
tomviner:issue-1496-xfail-cond-kw
May 31, 2016
Merged
issue 1496 - xfail with condition keyword #1524
RonnyPfannschmidt
merged 1 commit into
pytest-dev:master
from
tomviner:issue-1496-xfail-cond-kw
May 31, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomviner
force-pushed
the
issue-1496-xfail-cond-kw
branch
from
April 19, 2016 14:35
b8614a4
to
1b95739
Compare
Cool, many thanks! 😎 |
@RonnyPfannschmidt could you please take a look and merge if you are also OK with it? |
tomviner
force-pushed
the
issue-1496-xfail-cond-kw
branch
from
April 19, 2016 17:12
1b95739
to
99c4b6f
Compare
at first glance its ok will take a deeper look in a bit |
@RonnyPfannschmidt I just simplified a little. I've rebased this branch, but I've pushed the edit here: tomviner@4b5640a |
@RonnyPfannschmidt did you get a chance to take a better look on this? 😁 |
This was referenced Aug 23, 2016
Merged
This was referenced Sep 23, 2016
This was referenced Oct 1, 2017
This was referenced Oct 16, 2017
This was referenced Oct 29, 2017
This was referenced Nov 11, 2017
Merged
This was referenced Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1496 Xfail does not work with condition keyword argument.
We were only looking at
args
, despite the docs saying: