Fix misimport #12207
Closed
Fix misimport #12207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
force-pushed
the
fix-misimport
branch
from
6c0aa36
to
564e836
Compare
|
Superseded by #12208 |
|
This fix is actually interesting to have, as it simplifies the code a bit. Perhaps we can reopen it after #12208 gets merged. |
|
Reopened, I left it as draft for now |
nicoddemus
force-pushed
the
fix-misimport
branch
from
564e836
to
752c51c
Compare
|
With the new code this patch now breaks a bunch of tests. I think we can close this for now, or would you like to investigate more @flying-sheep ? |
|
No, that’s fine. If there’s more issues coming up, maybe we should remember that an avenue like this might fix these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.