WIP: Add a simple way to mark tests as xfail inside test #10096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: discuss API in pytest-dev#9027 TODO: write documentation TODO: write changelog entry TODO: add me to AUTHORS TODO: fix linting errors TODO: write proper commit message
manueljacob
force-pushed
the
mark_xfail_inside_test
branch
from
c1f9a5e
to
58f5e7b
Compare
RonnyPfannschmidt
requested changes
Jul 1, 2022
|
|
||
|
|
||
| def pytest_runtest_protocol(item: Item, nextitem: Optional[Item]) -> None: | ||
| current_item_var.set(item) |
There was a problem hiding this comment.
This is completely missing cleanup and self protection, it's basically breaking pytester in a hidden way
src/_pytest/skipping.py
Outdated
|
|
||
| def expect_failure(**kwargs) -> None: | ||
| # TODO: raise proper error, test | ||
| assert kwargs.get("run", True) |
There was a problem hiding this comment.
Just give the function a correct signature, run is not part of the equation here, don't allow it
There was a problem hiding this comment.
See also #10094.
TODO: put _XfailMarkDecorator fix into its own pull request TODO: squash into previous commit
manueljacob
force-pushed
the
mark_xfail_inside_test
branch
from
58f5e7b
to
d510bbe
Compare
|
@manueljacob would you like to pick this up again and see, if we can get it merged or would it be better to close and have a fresh go at a later point? |
obestwalter
added
the
status: needs information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9027.
TODO: discuss API in #9027
TODO: write documentation
TODO: write changelog entry
TODO: add me to AUTHORS
TODO: fix linting errors
TODO: write proper commit message