-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixture scope documentation #538
Comments
Original comment by Sorin Sbarnea (BitBucket: sorin, GitHub: sorin): I don't know I I should raise this as a different bug or keep it here. I wasn't able to find a solution for this in the documentaiton. I do have a set of unittests written using the python's unittest module. They are using the setUpModule() function to load a global variable with the shared "stuff" that is required to run the tests (including some http sesions). When run normally my tests was running fine but with py.test they are failing. I patched it a little bit to make it run using the old pytest fixture functions (which happen not to have same names as unittest ones). Worked but only when not executed on multiple threads, and that's a feature I do want to use. The documentation examples are useless in my case because I do have like 20 classes (unittest.TestCase) with 10 tests inside each class. Obviously I do not want to add a new parameter to each test. Until now I used the class setUp() method to load the shared dictionare inside self. |
I've read the documentation, and think the Sharing a fixture across tests in a module (or class/session) section makes this clear enough. Otherwise (this is a rough draft) how about:
|
Where would you add that paragraph @DuncanBetts? Perhaps we can discuss this over the PR itself? 😁 |
I plan to take care of this issue. Most of it has been added to the docs in the meantime, just needs some rounding out of the relevant sections. |
Awesome @bilderbuchi, thanks! |
Done, see #2848. |
Originally reported by: Mark Stacey (BitBucket: Gudahtt, GitHub: Gudahtt)
The fixture documentation briefly mentions the possibility of a fixture with class scope in the beginning summary, but it isn't mentioned anywhere else in the document. I had to check the source code to see if this was possible.
Also, I didn't see any mention that the default scope was "function" - it was implied, but not explicit.
I think it would be helpful to include a full list of available scopes, and to explicitly say that function scope is default. Both of these things are included in the docstring for the fixture function in the source code:
The text was updated successfully, but these errors were encountered: