recommended pytest-runner in setup_requires means packages fail to install often #3814
Labels
type: docs
documentation improvement, missing or needing clarification
Comments
graingert
changed the title
|
Going foward it's probably better to recommend only the conditional requirement https://github.com/pytest-dev/pytest-runner#conditional-requirement |
Zac-HD
added
the
type: docs
|
I agree - that section should at least discuss the downsides of using IMO we should present the manual option first, then discuss how this bypasses standard packaging tools, advise against it for libraries, and finally point to |
koobs
added a commit
to koobs/pynvim
that referenced
this issue
Dec 20, 2019
pytest runner should not be unconditionally included in setup_requires This change makes it conditional on setup.py invocation arguments as recommended upstream [1] See: pytest-dev/pytest#3814 [1] https://pytest-runner.readthedocs.io/en/latest/#conditional-requirement
justinmk
pushed a commit
to neovim/pynvim
that referenced
this issue
Jan 10, 2020
pytest runner should not be unconditionally included in setup_requires. This change makes it conditional on setup.py invocation arguments as recommended upstream [1]. See: pytest-dev/pytest#3814 Identified via: [FreeBSD Ports Bug 242065](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242065) Closes #417 Closes #420 [1] https://pytest-runner.readthedocs.io/en/latest/#conditional-requirement
andrew-propelauth
added a commit
to PropelAuth/propelauth-flask
that referenced
this issue
Feb 22, 2023
See more details here: https://pytest-runner.readthedocs.io/en/latest/#conditional-requirement and here: pytest-dev/pytest#3814
andrew-propelauth
added a commit
to PropelAuth/propelauth-py
that referenced
this issue
Feb 22, 2023
See more details here: https://pytest-runner.readthedocs.io/en/latest/#conditional-requirement and here: pytest-dev/pytest#3814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recommendation to add
pytest-runnertosetup_requiresmeans that all users of that package end up with an unnecessary pytest-runner package installed. This is bad because it bypasses pip hashes and--trusted-hosthttps://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner
MechanicalSoup/MechanicalSoup#224
rxcomm/pyaxo#26
jpadilla/pyjwt#179
The text was updated successfully, but these errors were encountered: