3.6.1 fails on "setup.py test"

[felixonmars]

The src/ restructure seems to break "setup.py test" here.

running test
/usr/bin/python: can't open file 'pytest.py': [Errno 2] No such file or directory

Changing the part in setup.py to call "src/pytest.py" fixes it here.

[pytestbot]

GitMate.io thinks possibly related issues are #18 (pytest-2.0.0 fails testing/test_nose.py on python-3.1.3), #1852 (test_doctest.py fails ), #2768 (Testing - Issue 1), #1980 (.), and #2851 (..).

[RonnyPfannschmidt]

that one is on me - we dont have a test for that bit so it was missed

[twmr]

we dont have a test for that bit so it was missed

I think that we should remove support for the test subcommand instead of fixing it. (see "Running the tests" in https://blog.ionelmc.ro/2014/05/25/python-packaging/)

[nicoddemus]

I agree that we should probably remove it, but I don't know for sure if that command is still widely used or not so please take my opinion with a grain of salt.

However searching for "setup.py test" in the PyPA only shows one result about testing with AppVeyor, so it doesn not seem to be the recommended practice.

Also I tried #3540 but unless I'm mistaken this has been broken for some time now, unless I'm missing something: #3540 (comment)

[twmr]

Note that the "setup.py test" integration is documented in the pytest docs: https://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner, but this doesn't mean that in the pytest repo python setup.py test needs to be supported.

[nicoddemus]

Can anybody confirm that setup.py test has been broken for some time now? If so I think it is fair to add a changelog entry and drop support for it.

@felixonmars do you have a specific use case for it, or you reported just because you found it broken (because you read it in the documentation or otherwise)?

Answered in #3540 (comment)

[nicoddemus]

Thanks everyone for the discussion. Closing in favor of #3536 #3543.

[twmr]

Closing in favor of #3536.

@nicoddemus could it be that you accidentally closed this #3536 ticket?

[nicoddemus]

Oops indeed, fixed, thanks!