-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit exception #3144
Comments
Hi @feuillemorte thanks for looking into this. This is somewhat more complicated than I expected because we have some moving parts to deal with. We need to make Together with the new exit code, I suggest we add a new
This is my take on this problem. @RonnyPfannschmidt what do you think? @feuillemorte I suggest to keep this on hold until we nail down the actual details. |
The code is different in this regard already: Lines 202 to 213 in 8bf343d
(via fc4aa27) So this might be improved/changed? (came here via #6257) |
Any more progress on this one? Just hit it in a separate instance. We have an In the meantime, is there a good workaround to the above? Specifically, is there a good way to gracefully fail the entire test suite when using xdist? |
Hi @vkomarov-r7,
Unfortunately it doesn't seem nobody got the time to sit down and work on this one yet.
I did spend some time now thinking about a possible workaround, but unfortunately couldn't think of any. 😕 I think the outline in #3144 (comment) is what would solve this correctly. |
We need to except Exit before this part of code:
pytest/_pytest/main.py
Lines 110 to 116 in 0d96a5b
and pass a message to xdist module
it needed for xdist:
original task:
pytest-dev/pytest-xdist#86
I'm ready to create pull request, but I don't know how to pass a message to xdist module, Please, give me an advice. Thanks!
The text was updated successfully, but these errors were encountered: