Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hook: pytest_runtest_logfinish #3101

Closed
nicoddemus opened this issue Jan 10, 2018 · 1 comment
Closed

New hook: pytest_runtest_logfinish #3101

nicoddemus opened this issue Jan 10, 2018 · 1 comment
Labels
type: feature-branch new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@nicoddemus
Copy link
Member

While looking for a solution to #3088, I realize we need a new hook that signals a test item has finished executing.

Without this hook one needs to implement pytest_runtest_logreport and juggle around the various setup, call and teardown reports to infer when a test item has finished running, which is downright problematic as pytest-dev/pytest-xdist#218 shows: there I had to implement a new "event" to signal that a test has been complete, which besides fixing a bug also allows pytest-rerunfailures to work with xdist.
@nicoddemus nicoddemus added type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: feature-branch new feature or API change, should be merged into features branch labels Jan 10, 2018
@pytestbot pytestbot added the plugin: xdist related to the xdist external plugin label Jan 10, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @RonnyPfannschmidt.

@pytestbot pytestbot added type: bug problem that needs to be addressed type: enhancement new feature or API change, should be merged into features branch labels Jan 10, 2018
@nicoddemus nicoddemus removed plugin: xdist related to the xdist external plugin type: bug problem that needs to be addressed type: enhancement new feature or API change, should be merged into features branch labels Jan 10, 2018
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Jan 10, 2018
@nicoddemus
Add new pytest_runtest_logfinish hook
b68b80a 
Fix pytest-dev#3101
@nicoddemus nicoddemus mentioned this issue Jan 10, 2018
Merged
alanbato pushed a commit to alanbato/pytest that referenced this issue Jan 24, 2018
@nicoddemus @alanbato
Add new pytest_runtest_logfinish hook
65021c4 
Fix pytest-dev#3101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature-branch new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicoddemus @pytestbot