Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automatic CHANGELOG management #2390

Closed
nicoddemus opened this issue May 4, 2017 · 12 comments · Fixed by #2431
Closed

Use automatic CHANGELOG management #2390

nicoddemus opened this issue May 4, 2017 · 12 comments · Fixed by #2431
Assignees

Comments

@nicoddemus
Copy link
Member

As suggested by @RonnyPfannschmidt, we want to adopt an automatic CHANGELOG file management to remove/reduce merge conflicts due to changes in the CHANGELOG file (which are quite common).

towncrier has been suggested as a good tool for this.

Here's what's needed:

  • Configure towncrier according to the instructions in its README;
  • Update instructions in CONTRIBUTING.rst related to the CHANGELOG;
  • Update instructions in .github/PULL_REQUEST_TEMPLATE.md;

Ideally we should tackle this right after the upcoming 3.1 release.

@RonnyPfannschmidt, you mentioned you wanted to do this?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus correct

@nicoddemus
Copy link
Member Author

Nice. I suggest we also adopt invoke to have well named tasks in place. You could introduce invoke and the first new task, generate_news or so (similar to what pip does in https://github.com/pypa/pip/blob/master/tasks/generate.py).

@RonnyPfannschmidt
Copy link
Member

@nicoddemus we first have to agree on some formatting tho - if we keep doing changelogs as is towncrier as is will be a pain

@nicoddemus
Copy link
Member Author

Looking at pip's changelog, the only difference I see is the fact that it doesn't generate links to the issues; that could be suggested upstream or even contributed by us.

If that's the only reason, I'm not against just using towncrier as is; I think switching to towncrier will be a huge maintenance improvement for us, so it out weights this small drawback.

@fschulze
Copy link
Contributor

fschulze commented May 4, 2017

We looked into towncrier for devpi and it was too opinionated for us. Your milage may vary. I'm currently throwing together an alternative after I didn't find anything else that matches what we would like.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus hence wanting to agree on formatting, not open up big cans of worm

@RonnyPfannschmidt
Copy link
Member

@fschulze, can you show me where it was too opinionated?

@nicoddemus
Copy link
Member Author

I looked at pip's NEWS.rst file and it looks good to me. I would like to contribute linking the issues automatically though, but I'm fine with starting using it now and enjoying the links later.

@nicoddemus
Copy link
Member Author

can you show me where it was too opinionated?

I'm curious as well. 😁

@fschulze
Copy link
Contributor

fschulze commented May 4, 2017

Turns out, it was just lacking documentation. After I looked again into how pip uses towncrier, I found the title_format and template options, which allow me to remove the opinionated stuff. Now there is only a small bug preventing towncrier to work with the template option on Python 3.x. Reporting it ...

@fschulze
Copy link
Contributor

fschulze commented May 4, 2017

And the issue is already fixed in 17.4.0 twisted/towncrier@c48a58f

@nicoddemus
Copy link
Member Author

@RonnyPfannschmidt with 3.1.0 being out, now it would be a good time to tackle this! 👍

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue May 23, 2017
fixes pytest-dev#2390 but still needs to integrate towncrier into release drafting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants