-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use automatic CHANGELOG management #2390
Comments
@nicoddemus correct |
Nice. I suggest we also adopt |
@nicoddemus we first have to agree on some formatting tho - if we keep doing changelogs as is towncrier as is will be a pain |
Looking at pip's changelog, the only difference I see is the fact that it doesn't generate links to the issues; that could be suggested upstream or even contributed by us. If that's the only reason, I'm not against just using towncrier as is; I think switching to towncrier will be a huge maintenance improvement for us, so it out weights this small drawback. |
We looked into towncrier for devpi and it was too opinionated for us. Your milage may vary. I'm currently throwing together an alternative after I didn't find anything else that matches what we would like. |
@nicoddemus hence wanting to agree on formatting, not open up big cans of worm |
@fschulze, can you show me where it was too opinionated? |
I looked at pip's |
I'm curious as well. 😁 |
Turns out, it was just lacking documentation. After I looked again into how pip uses towncrier, I found the |
And the issue is already fixed in 17.4.0 twisted/towncrier@c48a58f |
@RonnyPfannschmidt with |
fixes pytest-dev#2390 but still needs to integrate towncrier into release drafting
As suggested by @RonnyPfannschmidt, we want to adopt an automatic CHANGELOG file management to remove/reduce merge conflicts due to changes in the CHANGELOG file (which are quite common).
towncrier has been suggested as a good tool for this.
Here's what's needed:
towncrier
according to the instructions in its README;CONTRIBUTING.rst
related to the CHANGELOG;.github/PULL_REQUEST_TEMPLATE.md
;Ideally we should tackle this right after the upcoming
3.1
release.@RonnyPfannschmidt, you mentioned you wanted to do this?
The text was updated successfully, but these errors were encountered: