Unable to modify xml reports

[FuriousDuck]

It seems that this commit has broken an ability to modify stderr(out) via reporting hooks in xml reports which was pretty useful (because xml reports do not attach custom sections and record_xml_property doesn't work with pytest-xdist)

This code

@pytest.hookimpl(hookwrapper=True)
def pytest_runtest_makereport(item, call):
    outcome = yield
    report = outcome.get_result()
    if report.when == 'call':
        if report.skipped and 'xfail' in report.keywords or report.failed and 'xfail' not in report.keywords:
            try:
                fail_info = 'Fail detailed info:\n' + get_fail_info(item)
            except WebDriverException:
                fail_info = 'Fail detailed info:\n\nCaught a webdriver exception. Test session must have failed'
            report.sections.append(('Captured stdout call', fail_info))

is adding some strings to 'Captured stdout call' section of report. After this commit, strings are still visible in console log, but not in xml

[RonnyPfannschmidt]

@KKoukiou can you take a look at this?

[KKoukiou]

@FuriousDuck @RonnyPfannschmidt I took a look at this issue.
Please replace report.sections.append(('Captured stdout call', fail_info)) in your code
with: item.add_report_section(report.when, "stdout", fail_info) and tell me how it works.
It worked for me fine.

Thanks,
Katerina

[nicoddemus]

Thanks for looking into it @KKoukiou.

[nicoddemus]

@FuriousDuck any feedback?

[timyhou]

Glad I came across this. I was following this StackOverflow post as a guide. I also experienced the same issue with trying to append to Captured stdout and Captured stderr like the OP described.

However, @KKoukiou suggestion worked for me for stdout or stderr. This is a gem. I couldn't find any documentation describing the right way to modify report sections.

[nicoddemus]

Added docs in #2567

[FuriousDuck]

So sorry, missed my part. Like people said, @KKoukiou suggestion works great. Thank you