Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in skipif example #1224

Closed
zenhack opened this issue Dec 5, 2015 · 2 comments
Closed

Inconsistency in skipif example #1224

zenhack opened this issue Dec 5, 2015 · 2 comments
Labels
type: docs documentation improvement, missing or needing clarification

Comments

@zenhack
Copy link

zenhack commented Dec 5, 2015

The first two examples in this section of the documentation:

http://pytest.org/latest/skipping.html#skip-all-test-functions-of-a-class-or-module

Are internally inconsistent. The docstring for test_function says "will not be setup or run under 'win32' platform" (and the class name TestPosixCalls is suggestive of this), but the actual condition passed to skipif (as well as reason) is the opposite: the tests will only be run on windows
@nicoddemus
Copy link
Member

Good catch, thanks!

@nicoddemus nicoddemus added the type: docs documentation improvement, missing or needing clarification label Dec 5, 2015
nicoddemus added a commit that referenced this issue Dec 5, 2015
@nicoddemus
Fix inconsistency in skipif example
1bed514 
Fix #1224
@nicoddemus nicoddemus mentioned this issue Dec 5, 2015
Merged
@zenhack
Copy link
Author

zenhack commented Dec 5, 2015

You're welcome!

@nicoddemus nicoddemus mentioned this issue Dec 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenhack @nicoddemus