Merge pull request #2910 from RonnyPfannschmidt/scopenode-sanitize-sp…

…ecials switch a special case in scope node lookup to a general one
pytest-dev · Nov 10, 2017 · 99496d9 · 99496d9
2 parents c33074c + 0108f26
commit 99496d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/_pytest/fixtures.py b/_pytest/fixtures.py
@@ -27,10 +27,12 @@
 
 def pytest_sessionstart(session):
     import _pytest.python
+
     scopename2class.update({
         'class': _pytest.python.Class,
         'module': _pytest.python.Module,
         'function': _pytest.main.Item,
+        'session': _pytest.main.Session,
     })
     session._fixturemanager = FixtureManager(session)
 
@@ -62,8 +64,6 @@ def provide(self):
 def get_scope_node(node, scope):
     cls = scopename2class.get(scope)
     if cls is None:
-        if scope == "session":
-            return node.session
         raise ValueError("unknown scope")
     return node.getparent(cls)
 

diff --git a/changelog/2910.trivial b/changelog/2910.trivial
@@ -0,0 +1 @@
+Internal refactoring to simplify scope node lookup.