Merge pull request #3957 from asottile/changelog_files

Improve pre-commit detection for changelog filenames
pytest-dev · Sep 8, 2018 · 2c90b3d · 2c90b3d
2 parents 3dd2933 + 826adaf
commit 2c90b3d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -38,7 +38,8 @@ repos:
         language: python
         additional_dependencies: [pygments, restructuredtext_lint]
     -   id: changelogs-rst
-        name: changelog files must end in .rst
-        entry: ./scripts/fail
-        language: script
-        files: 'changelog/.*(?<!\.rst)$'
+        name: changelog filenames
+        language: fail
+        entry: 'changelog files must be named ####.(feature|bugfix|doc|removal|vendor|trivial).rst'
+        exclude: changelog/(\d+\.(feature|bugfix|doc|removal|vendor|trivial).rst|README.rst|_template.rst)
+        files: ^changelog/
diff --git a/changelog/3955.trivial.rst b/changelog/3955.trivial.rst
@@ -0,0 +1 @@
+Improve pre-commit detection for changelog filenames
diff --git a/scripts/fail b/scripts/fail
diff --git a/tox.ini b/tox.ini
@@ -48,7 +48,7 @@ commands =
 [testenv:linting]
 skip_install = True
 basepython = python3.6
-deps = pre-commit
+deps = pre-commit>=1.11.0
 commands = pre-commit run --all-files --show-diff-on-failure
 
 [testenv:py27-xdist]
@@ -195,7 +195,7 @@ passenv = *
 deps =
     colorama
     gitpython
-    pre-commit
+    pre-commit>=1.11.0
     towncrier
     wheel
 commands = python scripts/release.py {posargs}